Review: OrthCal

[Dimitrios - Georgios Kontopoulos]

2012/9/5 Bhavani Shankar R <bhavi at ubuntu.com>

> Thanks again but here are few more observations:
>
> - Is there any specific reason you list perl and python in both
> build-depends and depends?
>
Nope, I removed them.


> - the /usr/bin directory in the package is empty
> drwxr-xr-x root/root         0 2012-09-05 19:53 ./usr/bin/
> You should ideally remove it from the package
>
Done.


> - The d/copyright looks better but lintian throws out few warnings:
> W: orthcal source: missing-license-paragraph-in-dep5-copyright
> cc-by-nc-sa-2.0 (paragraph at line 35)
> W: orthcal source: missing-license-paragraph-in-dep5-copyright
> cc-by-nc-3.0 (paragraph at line 31)
>
> Maybe you should add small paragraph about what the license states
> after declaring the same (same goes with public-domain license too)
>
> This link can help you out I think:
>
> http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#examples

Done. The changes are pushed to Launchpad and packages will be built
shortly.

Regards,
Dimitrios
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20120905/271e9fa2/attachment.html>