Review: OrthCal

[Bhavani Shankar R]

On Wed, Sep 5, 2012 at 2:54 AM, Dimitrios - Georgios Kontopoulos
<dgkontopoulos at member.fsf.org> wrote:
> Hello again! I completed all the changes that you requested. The packages
> are currently being built by Launchpad.
>
> 2012/9/4 Bhavani Shankar R <bhavi at ubuntu.com>
>>
>> On Tue, Sep 4, 2012 at 2:10 PM, Dimitrios - Georgios Kontopoulos
>> <dgkontopoulos at member.fsf.org> wrote:
>>  > For some reason, the Exec part of the desktop file has to be
>> > "/usr/bin/perl /opt/extras.ubuntu.com/orthcal/bin/OrthCal.pl"
>> > in order for the launcher to start OrthCal.
>> >
>> > Removing 'perl' and listing only the script's location disables the
>> > launcher, even
>> > if the script has a correct Perl shebang and runs just fine from
>> > terminal. I
>> > am
>> > clueless as to why that happens. Please, tell me how I could change the
>> > desktop
>> > file and have the launcher work at the same time.
>> >
>>
>> Maybe perl program while executing looks for the full path in .desktop
>> file. You can override the warning if you wish.
>
> I found out the source of the problem. I had to enter an extra line at the
> .desktop file, containing
> StartupWMClass=OrthCal.pl
> Now everything works perfectly, even without perl at the Exec command.
>

Seems good now! Thanks!

>> >> As a side note: The saints.db file is good :) (If you had got this
>> >> from somewhere it is advisable to mention their name in a file called
>> >> CONTRIBUTORS in the src package and a mention in d/copyright)
>> >
>> > The db file contains entries for daily feasts from two websites
>> > currently.
>> > Orthodoxwiki.org -for english content- and saint.gr -for greek content.
>> > I
>> > wrote
>> > myself a script to extract the information from these two sources.
>> >
>> > The first source offers all content under a CC BY-SA 2.5 license.
>> >
>>
>> You can put any authors name and the file under a license in d/copyright
>>
>> See:
>> http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification
>>
>> > Saint.gr on the other hand does not offer a specific license. Rather,
>> > they
>> > mention
>> > "freely ye have received, freely give" in Greek, explaining that anyone
>> > can
>> > use the
>> > content for any purpose, even without citing its source.
>> >
>> > I am citing both these sources in the about section of OrthCal. How can
>> > I
>> > refer to
>> > saint.gr's license in debian/copyright? Also, how do I explain about the
>> > db
>> > having
>> > content coming under two different licenses? In the future, more
>> > languages
>> > might
>> > be added, leading to perhaps other licenses as well.
>> >
>>
>> You can list the source and put the saints.gr file under public-domain I
>> guess
>>
>> http://en.wikipedia.org/wiki/Public_domain
>
> Done.
>

Thanks again but here are few more observations:

- Is there any specific reason you list perl and python in both
build-depends and depends?
- the /usr/bin directory in the package is empty
drwxr-xr-x root/root         0 2012-09-05 19:53 ./usr/bin/
You should ideally remove it from the package
- The d/copyright looks better but lintian throws out few warnings:
W: orthcal source: missing-license-paragraph-in-dep5-copyright
cc-by-nc-sa-2.0 (paragraph at line 35)
W: orthcal source: missing-license-paragraph-in-dep5-copyright
cc-by-nc-3.0 (paragraph at line 31)

Maybe you should add small paragraph about what the license states
after declaring the same (same goes with public-domain license too)

This link can help you out I think:

http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#examples

Regards,



-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi