Review: Wake On Plan

[Bhavani Shankar R]

On Fri, Jul 13, 2012 at 12:08 AM, Martin Owens <doctormo at gmail.com> wrote:
> Review Done:
>
> App: https://myapps.developer.ubuntu.com/dev/apps/1188/
> Branch: lp:~ubuntu-app-review-contributors/ubuntu-app-reviews/wakeonplan
>
> License Check: GPLv3, missing file:
>
> wakeonplan/read_rtc.py: *No copyright* UNKNOWN
>
> Functionality Check: All Working (12.04)
>
> Lint Results:
>
> W: This app seems to list cdbs as a Build-Depends in debian/control, but
>    does not use it in debian/rules. It should be safe to remove it in
>    debian/control.
> W: You might want to update the Standards-Version in debian/control to
>    version 3.9.3.
> W: This package does not use DEP-5, which provides a machine-readable
>    debian/copyright file. You might want to review
>    http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ to
>    find out how to accomplish it. http://bazaar.launchpad.net/~dholbach
>    /ubuntu-app-reviews/harvestwidget/view/head:/debian/copyright has a
> live
>    example for a simple app.
>
>


Hi Serhiy,

Apologies for the late response. Just had a look at the latest PPA package.

A couple of things I found:

d/control and d/compat debhelper version not matching (6 v/s 8)
d/control has a spell mistake s/neccessary/necessary
The package has an empty dir

drwxr-xr-x root/root         0 2012-11-21 20:18
./opt/extras.ubuntu.com/wakeonplan/share/gnome/help/wakeonplan/C/figures/

Maybe the preferences and index.page intended to go in here?

Anyway, these being straight forward,

+1 for this app

-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi