[Vote] pictoric

Bhavani Shankar R bhavi at ubuntu.com
Mon Jul 30 16:13:46 UTC 2012


On Mon, Jul 30, 2012 at 11:24 AM, Alexander Kendrick
<kentalex8 at gmail.com> wrote:
> Sorry about that, I found my mistake. When I went to check my .bashrc
> entries, I had DEBMAIL instead of DEBEMAIL. Quickly now works fine, and the
> changelog has my correct email.
>
> Thanks for finding those. I updated the copyright to the reflect the
> standard in the website you provided, and also made similar formatting
> changes to control. I'm pretty sure I have taken care of all of the lintian
> warnings now, when I run lintian on my local machine there are no warnings.
>
> I uploaded the new version to our launchpad site and ppa.
>
> Thanks,
> Alex
>

Dear Alex,

Thanks for the update. Most looks fine on a overview but lintian shows
this still when checked:

I: pictoric source: binary-control-field-duplicates-source field
"homepage" in package pictoric
I: pictoric source: binary-control-field-duplicates-source field
"priority" in package pictoric

When looked at d/control we find:

bhavani at bhavani-spagetti-monster:~/arb/pictoric-updated/pictoric-2.3.3$
cat debian/control
Source: pictoric
Section: python
Priority: extra
Maintainer: Glacier Apps <glacier.apps at gmail.com>
Uploaders: Coleman Kendrick <cole_jk at cybermesa.com>, Alexander
Kendrick <alex_k at cybermesa.com>
Build-Depends: debhelper (>= 8), libglib2.0-bin, python (>= 2.6.6-3~),
 python-distutils-extra (>= 2.10)
Standards-Version: 3.9.3
XS-Python-Version: current
Homepage: https://launchpad.net/pictoric

Package: pictoric
Architecture: all
Priority: extra
XB-Python-Version: ${python:Versions}
Depends: ${misc:Depends},
 ${python:Depends},
 gir1.2-glib-2.0,
 gir1.2-gtk-3.0,
 gir1.2-launchpad-integration-3.0,
 gir1.2-gdkpixbuf-2.0,
 yelp
Homepage: https://launchpad.net/pictoric
Description: Create a desktop slideshow
 Easily create a desktop slideshow in less a minute

Ideally you would remove the Homepage and Priority field from Package stanza.

You would also like to include 3.0(native) as source format in
debian/source/format

+1 based on the condition that above nitpicks are fixed.

Regards,

-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi



More information about the App-review-board mailing list