[Vote] Monxcleyr Soundboard

[Stéphane Graber]

On 07/10/2012 10:17 AM, Stéphane Graber wrote:
> On 07/10/2012 05:29 AM, Daniel Holbach wrote:
>> Hello everybody,
>>
>> I had a look over Monxcleyr Soundboard and after a few small changes,
>> which I pushed to
>>
>>   lp:~dholbach/ubuntu-app-reviews/monxcleyr-soundboard
>>
>> it looks ready to go. Please vote.
>>
>> Have a great day,
>>  Daniel
>>
> 
>  - debhelper version mismatch between debian/compat and debian/control.
> 
> W: monxcleyr-soundboard source:
> package-needs-versioned-debhelper-build-depends 8
> W: monxcleyr-soundboard source:
> debhelper-overrides-need-versioned-build-depends (>= 7.0.50~)
> W: monxcleyr-soundboard: possible-unindented-list-in-extended-description
> 
> W: monxcleyr-soundboard: script-not-executable
> opt/extras.ubuntu.com/monxcleyr-soundboard/monxcleyr_soundboard/soundboard.py
> 
> ^ haven't checked if that file is actually called from anywhere, but it
> contains a shebang and is clearly a python executable, so it should be
> marked executable on disk.
> 
> 
> No vote at this point, will review again once these have been fixed.

debian/copyright is also invalid, the DEP5 format URL is wrong.



-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20120710/45a93eac/attachment.pgp>