[Vote] Monxcleyr Soundboard
Jonathan Carter (highvoltage)
jonathan at ubuntu.com
Tue Jul 10 15:04:12 UTC 2012
On 2012-07-10 10:17, Stéphane Graber wrote:
> On 07/10/2012 05:29 AM, Daniel Holbach wrote:
> W: monxcleyr-soundboard source:
> package-needs-versioned-debhelper-build-depends 8
> W: monxcleyr-soundboard source:
> debhelper-overrides-need-versioned-build-depends (>= 7.0.50~)
> W: monxcleyr-soundboard:
> possible-unindented-list-in-extended-description
>
> W: monxcleyr-soundboard: script-not-executable
>
> opt/extras.ubuntu.com/monxcleyr-soundboard/monxcleyr_soundboard/soundboard.py
>
> ^ haven't checked if that file is actually called from anywhere, but
> it
> contains a shebang and is clearly a python executable, so it should
> be
> marked executable on disk.
>
>
> No vote at this point, will review again once these have been fixed.
I haven't tested it, but the packaging looks ok and it doesn't seem to
do anything crazy. I can give it a conditional +1 so long as somebody
tests it. (sorry for not being more useful than that)
-Jonathan
More information about the App-review-board
mailing list