[Vote] FlashGen

Bhavani Shankar R bhavi at ubuntu.com
Tue Jul 10 14:29:57 UTC 2012


On Tue, Jul 10, 2012 at 7:29 PM, Stéphane Graber <stgraber at ubuntu.com> wrote:
> On 07/10/2012 04:27 AM, Daniel Holbach wrote:
>> Hello everybody,
>>
>> I had a quick look over flashgen and to me it looks ready to go. Here's
>> a branch with some (very small) changes:
>>
>>   lp:~dholbach/ubuntu-app-reviews/flashgen
>>
>> Have a great day,
>>  Daniel
>>
>
> 13:55 < stgraber> dholbach: for flashgen, only "issue" I found is that
> /opt/extras.ubuntu.com/flashgen/flashgen_lib/edict.py shouldn't have a
> shebang as it's not an executable
>                   script (just meant to be imported)
>
> Would be great to encourage these developers to not include the shebang
> for non-executable files, it's the second app I spotted with that
> mistake, so I'm wondering if maybe it's a quickly bug?
>
> Anyway, won't block the vote on that. +1
>

+1 here

Regards


-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi



More information about the App-review-board mailing list