[Vote] FlashGen

[Stéphane Graber]

On 07/10/2012 04:27 AM, Daniel Holbach wrote:
> Hello everybody,
> 
> I had a quick look over flashgen and to me it looks ready to go. Here's
> a branch with some (very small) changes:
> 
>   lp:~dholbach/ubuntu-app-reviews/flashgen
> 
> Have a great day,
>  Daniel
> 

13:55 < stgraber> dholbach: for flashgen, only "issue" I found is that
/opt/extras.ubuntu.com/flashgen/flashgen_lib/edict.py shouldn't have a
shebang as it's not an executable
                  script (just meant to be imported)

Would be great to encourage these developers to not include the shebang
for non-executable files, it's the second app I spotted with that
mistake, so I'm wondering if maybe it's a quickly bug?

Anyway, won't block the vote on that. +1


-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20120710/e6672317/attachment.pgp>