bottles
Stéphane Graber
stgraber at ubuntu.com
Mon Jan 16 14:11:21 UTC 2012
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 01/16/2012 08:23 AM, Jonathan Carter (highvoltage) wrote:
> Holas, ARB Board
>
> I'm still trying to get into the ARB swing of things, I've resolved
> to focus on at least one package a week.
>
> Today I checked the newest app that landed in my inbox: bottles
> Link: https://myapps.developer.ubuntu.com/dev/apps/540/
>
> Here are some things I noticed about it (let me know if I'm
> pedantic about anything):
>
> * Package version (0.1-1) is higher than upstream VERSION file
> (0.0.1) * Files are installed in the usual FHS locations (not in
> /opt) * The license seems to be the MIT license, but it doesn't
> explicitly say that it's the MIT license anywhere. It should
> probably include it in the copyright file so that it's dep5
> compliant for stats, etc. * The target release is Precise. If
> that's the intention then it's surely a better candidate for
> Universe? * There's an uncommitted quilt patch that prevents the
> package to build for me: """ dpkg-source: info: using source format
> `3.0 (quilt)' dpkg-source: info: building bottles using existing
> ./bottles_0.1.orig.tar.gz dpkg-source: info: local changes
> detected, the modified files are: bottles-0.1/lib/bottles/paths.rb
> """ - After a "dpkg-source --commit" it builds fine. * It runs
> fine, it's a nice little app.
>
> What should I do next? I guess I should tell the submitter that
> for precise, it's probably better that we upload the package to
> universe? I'm willing to assist with the few things that need
> fixing and sponsor it. Any suggestions/feedback/ideas?
>
> -Jonathan
Thanks for the review.
I think at this point you should basically send these notes as "Need
information" on MyApps and tell the uploader that if he indeed wants
the app in Precise, he needs to go through the regular packaging channel.
Thought it might be a case where he simply used the wrong target
distro and actually wanted it for Ubuntu 11.10, if that's the case,
then he should simply update the packaging based on your notes and
submit the updated tarball to MyApps.
- --
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBCgAGBQJPFDAJAAoJEMY4l01keS1nWQcQAIzSBUmcHJILHC9DAjnsE9H2
Kq/pYe5HKXR1B9EC6cMWx6+abINPn5qcBhlpId75qRcfVw/bQ8L6mWgA9oY+cSRf
tUKDul8W4by7ahaB48RUXwvzPoA6l8V8H5dgJG2iSOGmqDK4vmVVepbOzNNOt/5J
2Y9n+aGitgt1/9/Oxhs3KM6QSEXNF5zEB6484mC84ixKFOEzGLGzDqmibEZZ/S4C
gUAxoWZVHkmPoJwVe8l52fSr4BDZx3Oi7MqENDtOD+bMtju4fcA87AG33uBfJmd7
7DYJ6gtt6w1I18I+W1443aktXn0xDkG51HlwffN598K3tSR2AEyQrP1hFlP6UoNd
WwuHB9jPOnaEmK7dVBbAZiosGcsmGsp71TGjEh34fTk9+m+wHAeQAcQkIIAKcATm
WbA+nMyRWDsy87TswMvRioSDDNO8KE+oyqxcycmelxyEAydYHH/NdNzR1M16aPP7
vcVcb4+Rehuuc7zxYk60Ah/Yy33NReyfl5N+038nIhx49VL3ahWi42qOvoDByM9s
rckn3PcprJ1jTdgwVf0UPnP5mc3a7VrHj4hHv+L4+4Ym1AnMjUmlhKVC3AFkUGPx
Ls9TQscY/geteQEymd6jndCV1iiu7BLsd4aLIsx8UTjJi3s5VxoTZ36SZl2po7Mf
8FjBSfnTKJPBOB4KV8G9
=ajk8
-----END PGP SIGNATURE-----
More information about the App-review-board
mailing list