bottles

Jonathan Carter (highvoltage) jonathan at ubuntu.com
Mon Jan 16 13:23:40 UTC 2012


Holas,  ARB Board

I'm still trying to get into the ARB swing of things, I've resolved to
focus on at least one package a week.

Today I checked the newest app that landed in my inbox: bottles
Link: https://myapps.developer.ubuntu.com/dev/apps/540/

Here are some things I noticed about it (let me know if I'm pedantic
about anything):

 * Package version (0.1-1) is higher than upstream VERSION file (0.0.1)
 * Files are installed in the usual FHS locations (not in /opt)
 * The license seems to be the MIT license, but it doesn't explicitly
say that it's the MIT license anywhere. It should probably include it in
the copyright file so that it's dep5 compliant for stats, etc.
 * The target release is Precise. If that's the intention then it's
surely a better candidate for Universe?
 * There's an uncommitted quilt patch that prevents the package to build
for me:
   """
   dpkg-source: info: using source format `3.0 (quilt)'
   dpkg-source: info: building bottles using existing
   ./bottles_0.1.orig.tar.gz
   dpkg-source: info: local changes detected, the modified files are:
     bottles-0.1/lib/bottles/paths.rb
   """
   - After a "dpkg-source --commit" it builds fine.
 * It runs fine, it's a nice little app.

What should I do next? I guess I should tell the submitter that for
precise, it's probably better that we upload the package to universe?
I'm willing to assist with the few things that need fixing and sponsor
it. Any suggestions/feedback/ideas?

-Jonathan



More information about the App-review-board mailing list