Review: Unity-lens-pypi

[Andrew Mitchell]

On Mon, Dec 10, 2012 at 08:27:28PM +0530, Bhavani Shankar R wrote:
> On Sat, Nov 24, 2012 at 11:45 PM, Bhavani Shankar R <bhavi at ubuntu.com> wrote:
> > On Thu, Nov 22, 2012 at 9:25 PM, Bhavani Shankar R <bhavi at ubuntu.com> wrote:
> >> On Fri, Nov 16, 2012 at 9:39 PM, Bhavani Shankar R <bhavi at ubuntu.com> wrote:
> >>> Dear Chris,
> >>>
> >>> As per our discussion on IRC, just had a look at your unity-lens-pypi app.
> >>>
> >>> The packaging and the code looks fine although I dint build or test
> >>> the package. good packaging again :)
> >>>
> >>> Only thing which was of concern was the usage of python logo on the
> >>> lens (Thanks to Allison for her useful inputs on the IRC regarding the
> >>> same)
> >>>
> >>> I'll have another look when the python logo part gets sorted out.
> >>>
> >>
> >> Hey Chris,
> >>
> >> Thanks for the headsup here:
> >>
> >> https://lists.ubuntu.com/archives/app-review-board/2012-November/002587.html
> >>
> >> But I found a small nitpick; d/rules needs a bit of tweaking I guess
> >>
> >> dpkg-buildpackage -rfakeroot -d -us -uc -S -sa
> >> dpkg-buildpackage: source package unity-lens-pypi
> >> dpkg-buildpackage: source version 0.8-extras12.10.1
> >> dpkg-buildpackage: source changed by Chris Wayne <chris.wayne at canonical.com>
> >>  dpkg-source --before-build unity-lens-pypi
> >>  fakeroot debian/rules clean
> >> debian/rules:7: *** missing separator (did you mean TAB instead of 8
> >> spaces?).  Stop.
> >> dpkg-buildpackage: error: fakeroot debian/rules clean gave error exit status 2
> >> debuild: fatal error at line 1357:
> >> dpkg-buildpackage -rfakeroot -d -us -uc -S -sa failed
> >>
> >> Maybe at line 7 you gave 8 spaces instead of a tab.
> >>
> >
> >
> > +1 based on latest branch.
> >
> >
> > Great job again Chris!
> > --
> > Bhavani Shankar
> > Ubuntu Developer       |  www.ubuntu.com
> > https://launchpad.net/~bhavi
> 
> Hi Andrew/Alessio,
> 
> Your feedback please. :-)
> 
> Regards,
> 

I haven't tested the functionality, but package looks fine, +1.

Andrew