Review of TeaTime

[Bhavani Shankar R]

On Tue, Dec 11, 2012 at 3:17 AM, Ian Berke <ian.berke at gmail.com> wrote:
> Hi,
>
> Wishing to help the ARB start making a dent in some of the apps waiting for
> review (including mine), I downloaded the tar.gz file for TeaTime from:
> https://myapps.developer.ubuntu.com/dev/apps/313/
>
> TeaTime is a very simple timer application.  The package works and builds
> fine with debuild and has a GPL3 license in debian/copyright. It installs
> into /opt/extras.ubuntu.com/teatime although the developer renamed the
> source package to teatime-unity (because of another package called teatime;
> causes some errors in arb-lint).  The output from arb-lint is as follows:
>
> ian at ubuntu:~/pythontesting/arb-review/teatime$ arb-lint
> W: The ARB wants only one changelog entry in debian/changelog, so you might
>    want to collate all the relevant information in one changelog entry
>    under the last version and date.
> W: This package does not use DEP-5, which provides a machine-readable
>    debian/copyright file. You might want to review
>    http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ to
>    find out how to accomplish it. http://bazaar.launchpad.net/~dholbach
>    /ubuntu-app-reviews/harvestwidget/view/head:/debian/copyright has a live
>    example for a simple app.
> E: The package seems to contain no files in '/opt/extras.ubuntu.com
>    /teatime-unity' which indicates a problem with the installation of
>    files.
> E: These files are outside opt/extras.ubuntu.com/teatime-unity and
>    shouldn't be:
>    - usr/lib/python2.7/dist-packages/teatime-12.06.egg-info
>    - usr/share/pyshared/teatime-12.06.egg-info
>    - opt/extras.ubuntu.com/teatime/window.ui
>    - opt/extras.ubuntu.com/teatime/teatime.py
>    - opt/extras.ubuntu.com/teatime/locale/en_GB/LC_MESSAGES/teatime.mo
>    - opt/extras.ubuntu.com/teatime/locale/el/LC_MESSAGES/teatime.mo
>  ..... (more .mo files)
>
> The python program is pretty simple and stores its saved timers in
> ~/.local/share/teatime.js (json format). I don't know if that's ok as the
> guidelines say configuration data should be stored in ~/.config/teatime
>
> I hope this review is helpful. Please let me know if I should include other
> information, or if certain things are not needed. Also attached is the
> output from debbuild and arb-lint in a text file. I plan to do a few reviews
> over the next couple of weeks.
>
> Best,
> Ian
>

Dear Ian,

Thank you very much for your help in the reviews and its highly appreciated.

Firstly, Regarding the app:- from what I see the developer has changed
the name to teatime-unity so the app should ideally be installed in
/opt/extras.ubuntu.com/teatime-unity as the arb-lint error says.

We've created a simple walk-through guide in how to package an
application to meet the requirements for app submission process.

https://wiki.ubuntu.com/AppReviewBoard/Submissions/PackageQuickStart

Secondly, You should consider joining the
ubuntu-app-review-contributors team here:

https://launchpad.net/~ubuntu-app-review-contributors/

Thanks again for your offer of help!

Regards,
-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi