Review of TeaTime

[Ian Berke]

Hi,

Wishing to help the ARB start making a dent in some of the apps waiting for
review (including mine), I downloaded the tar.gz file for TeaTime from:
https://myapps.developer.ubuntu.com/dev/apps/313/

TeaTime is a very simple timer application.  The package works and builds
fine with debuild and has a GPL3 license in debian/copyright. It installs
into /opt/extras.ubuntu.com/teatime although the developer renamed the
source package to teatime-unity (because of another package called teatime;
causes some errors in arb-lint).  The output from arb-lint is as follows:

ian at ubuntu:~/pythontesting/arb-review/teatime$ arb-lint
W: The ARB wants only one changelog entry in debian/changelog, so you might
   want to collate all the relevant information in one changelog entry
   under the last version and date.
W: This package does not use DEP-5, which provides a machine-readable
   debian/copyright file. You might want to review
   http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ to
   find out how to accomplish it. http://bazaar.launchpad.net/~dholbach
   /ubuntu-app-reviews/harvestwidget/view/head:/debian/copyright has a live
   example for a simple app.
E: The package seems to contain no files in '/opt/extras.ubuntu.com
   /teatime-unity' which indicates a problem with the installation of
   files.
E: These files are outside opt/extras.ubuntu.com/teatime-unity and
   shouldn't be:
   - usr/lib/python2.7/dist-packages/teatime-12.06.egg-info
   - usr/share/pyshared/teatime-12.06.egg-info
   - opt/extras.ubuntu.com/teatime/window.ui
   - opt/extras.ubuntu.com/teatime/teatime.py
   - opt/extras.ubuntu.com/teatime/locale/en_GB/LC_MESSAGES/teatime.mo
   - opt/extras.ubuntu.com/teatime/locale/el/LC_MESSAGES/teatime.mo
 ..... (more .mo files)

The python program is pretty simple and stores its saved timers in
 ~/.local/share/teatime.js (json format). I don't know if that's ok as the
guidelines say configuration data should be stored in ~/.config/teatime

I hope this review is helpful. Please let me know if I should include other
information, or if certain things are not needed. Also attached is the
output from debbuild and arb-lint in a text file. I plan to do a few
reviews over the next couple of weeks.

Best,
Ian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20121210/9bbe504c/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: teatime.notes
Type: application/octet-stream
Size: 16789 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20121210/9bbe504c/attachment-0001.obj>