[Vote] Fogger

[Michael Hall]

I fixed the control and copyright files, my branch is:

https://code.launchpad.net/~mhall119/fogger/fixes-for-stephane/

Note that because Allison added "-0extras12.04.1" to the version number
in the changelog file, "bzr bd" expects there to be an upstream
.orig.tar.gz available and fails when one doesn't exist.  To make it
build from the source in the branch, you will need to run "bzr bd
--split", which will first create the .orig.tar.gz file.

Michael Hall
mhall119 at ubuntu.com

On 08/01/2012 05:15 PM, Stéphane Graber wrote:
> On 07/27/2012 02:35 PM, Owas Lone wrote:
>> On Fri, Jul 27, 2012 at 11:26 PM, Allison Randal <allison at ubuntu.com> wrote:
>>> On 07/21/2012 11:25 AM, Owas Lone wrote:
>>>> Updated the branch lp:~loneowais/fogger/arb-review to the latest from
>>>> lp:~loneowais/fogger/quickly_trunk which is used for PPA builds
>>>> (ppa:loneowais/fogger)
>>>
>>> Confirmed that this latest update includes the fixes stgraber requested.
>>> I also did a more detailed code review of the Javascript bridge, and
>>> approve. (I've written a couple of these now, they're safe when input is
>>> properly filtered.)
>>>
>>> A couple of quick fixes:
>>>
>>> - Update the fields of debian/copyright to the current format (see
>>> https://wiki.ubuntu.com/AppReviewBoard/Submissions/QuicklyTips)
>>>
>>> - Add "-extras12.04.1" to the version in debian/changelog.
>>>
>>> +1, conditioned on these final 2 changes
>>>
>>> Allison
>>
>> Hi Allison,
>>
>> I've pushed the requested fixes to lp:~loneowais/fogger/arb-review
>>
>> Thank you!
> 
>  - Package doesn't build when doing "bzr bd"
>  - The GPL-3 is defined twice in debian/copyright (the one at the bottom
> is enough)
>  - debian/control build-depends on cdbs but you aren't using it
> 
> The package not being buildable prevents me from finishing the review,
> so sticking to my -1 for now.
> 
> 
> 
>