[Vote] Fogger

[Stéphane Graber]

On 07/27/2012 02:35 PM, Owas Lone wrote:
> On Fri, Jul 27, 2012 at 11:26 PM, Allison Randal <allison at ubuntu.com> wrote:
>> On 07/21/2012 11:25 AM, Owas Lone wrote:
>>> Updated the branch lp:~loneowais/fogger/arb-review to the latest from
>>> lp:~loneowais/fogger/quickly_trunk which is used for PPA builds
>>> (ppa:loneowais/fogger)
>>
>> Confirmed that this latest update includes the fixes stgraber requested.
>> I also did a more detailed code review of the Javascript bridge, and
>> approve. (I've written a couple of these now, they're safe when input is
>> properly filtered.)
>>
>> A couple of quick fixes:
>>
>> - Update the fields of debian/copyright to the current format (see
>> https://wiki.ubuntu.com/AppReviewBoard/Submissions/QuicklyTips)
>>
>> - Add "-extras12.04.1" to the version in debian/changelog.
>>
>> +1, conditioned on these final 2 changes
>>
>> Allison
> 
> Hi Allison,
> 
> I've pushed the requested fixes to lp:~loneowais/fogger/arb-review
> 
> Thank you!

 - Package doesn't build when doing "bzr bd"
 - The GPL-3 is defined twice in debian/copyright (the one at the bottom
is enough)
 - debian/control build-depends on cdbs but you aren't using it

The package not being buildable prevents me from finishing the review,
so sticking to my -1 for now.


-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20120801/1a22cd14/attachment.pgp>