Basenji
Shane Fagan
shanepatrickfagan at ubuntu.com
Fri Oct 1 23:04:25 BST 2010
On Fri, 2010-10-01 at 22:37 +0100, Allison Randal wrote:
> Recommend bumping this application back to REVU.
>
> ------
> Packaging
> The application is well packaged using the Debian packaging system
>
> -1
>
> Still has problems with some fundamental Debian packaging elements
> (installing images in /usr/lib, no manpage for binary, etc). Commented
> in REVU that he "doesn't have time to fix the errors".
>
>
> ------
> Packaging
> Includes suitable Copyright and licensing content
>
> -1
>
> Debian copyright file does not mention files with a different owner and
> copyright. Some source files are listed as GPL 2.1, some are owned by
> Scott Peterson and appear to be MIT license. It appears that he's sucked
> in a modified version of another project
> (http://musicbrainz.org/doc/MusicbrainzSharp) and not mentioned it in
> the copyright file. Also another file copyright Novell
> (VolumeDB/DecoderUtility.cs), GPL 3 license is not mentioned in the
> copyright file.
>
> -------
> Run Test
> Does not perform any malicious actions
>
> 0
>
> Code review needed, of 1000s of lines of C# code.
>
>
> ------
> (Added) Content
> Content is suitable under criteria of PostReleaseApps process
>
> -1
>
> - Installs outside of /opt.
> - Pushing the boundaries on the "complexity" scale. Contains multiple
> library files, "theme" switching capability, 1000s of lines of code.
>
> Allison
>
Hey Allison,
I sent a message to the list about a week or two ago about /opt not
being a requirement on this cycle of the ARB because of the current
system doesnt exactly support it and since Quickly which is one of the
things we would prefer application developers to use isnt using /opt
either. Since no one else commented on the list about it I just presumed
that pushing the requirement to 11.04 was all good.
--fagan
More information about the App-review-board
mailing list