Basenji

Allison Randal allison.randal at canonical.com
Fri Oct 1 22:37:16 BST 2010


Recommend bumping this application back to REVU.

------
Packaging
The application is well packaged using the Debian packaging system

-1

Still has problems with some fundamental Debian packaging elements
(installing images in /usr/lib, no manpage for binary, etc). Commented
in REVU that he "doesn't have time to fix the errors".


------
Packaging
Includes suitable Copyright and licensing content

-1

Debian copyright file does not mention files with a different owner and
copyright. Some source files are listed as GPL 2.1, some are owned by
Scott Peterson and appear to be MIT license. It appears that he's sucked
in a modified version of another project
(http://musicbrainz.org/doc/MusicbrainzSharp) and not mentioned it in
the copyright file. Also another file copyright Novell
(VolumeDB/DecoderUtility.cs), GPL 3 license is not mentioned in the
copyright file.

-------
Run Test
Does not perform any malicious actions
	
0

Code review needed, of 1000s of lines of C# code.


------
(Added) Content
Content is suitable under criteria of PostReleaseApps process

-1

- Installs outside of /opt.
- Pushing the boundaries on the "complexity" scale. Contains multiple
library files, "theme" switching capability, 1000s of lines of code.

Allison



More information about the App-review-board mailing list