[Bug 206867] Re: xfce4-autostart-editor crashed with SIGSEGV

[Urs Fleisch]

I have this crash with Hardy Beta. To find out what happens I recompiled
the program. Here is the backtrace:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb731e720 (LWP 13307)]
xfae_item_free (item=0x0) at xfae-model.c:508
(gdb) bt
#0  xfae_item_free (item=0x0) at xfae-model.c:508
#1  0x0804c167 in xfae_item_new (relpath=<value optimized out>) at xfae-model.c:495
#2  0x0804d365 in xfae_model_init (model=0x8084008) at xfae-model.c:136
#3  0xb7772f46 in g_type_create_instance () from /usr/lib/libgobject-2.0.so.0
#4  0xb7758242 in ?? () from /usr/lib/libgobject-2.0.so.0
#5  0x0809cd60 in ?? ()
#6  0x00000000 in ?? ()
(gdb) 

Looking at xfae_item_new() in xfae-model.c, item is only allocated if
"Type" is "Application", but at the end of the function passed to
xfae_item_free(), where it is dereferenced, also if it is NULL. To
reproduce the bug, you only need a desktop entry with a "Type" which is
not "Application", e.g. adept_notifier_auto.desktop:

grep -n "Type=Service" /etc/xdg/autostart/*
/etc/xdg/autostart/adept_notifier_auto.desktop:21:Type=Service

Here's a little patch to fix the bug:

--- xfce4-session-4.4.2/xfce4-autostart-editor/xfae-model.c.orig	2007-11-17 20:31:05.000000000 +0100
+++ xfce4-session-4.4.2/xfce4-autostart-editor/xfae-model.c	2008-04-07 19:18:15.000000000 +0200
@@ -490,7 +490,7 @@ xfae_item_new (const gchar *relpath)
       xfce_rc_close (rc);
 
       /* check if we should skip the item */
-      if (G_UNLIKELY (skip))
+      if (G_UNLIKELY (skip) && item)
         {
           xfae_item_free (item);
           item = NULL;


** Attachment added: "Patch to fix xfce4-autostart-editor crash"
   http://launchpadlibrarian.net/13177022/xfce4-autostart-segfault.patch

-- 
xfce4-autostart-editor crashed with SIGSEGV
https://bugs.launchpad.net/bugs/206867
You received this bug notification because you are a member of Xubuntu
Team, which is subscribed to xfce4-session in ubuntu.