[Merge] lp:~jamesodhunt/upstart/bug-1447756-the-actual-fix into lp:upstart

James Hunt james.hunt at canonical.com
Wed May 13 15:53:23 UTC 2015


James Hunt has proposed merging lp:~jamesodhunt/upstart/bug-1447756-the-actual-fix into lp:upstart.

Requested reviews:
  Upstart Reviewers (upstart-reviewers)
Related bugs:
  Bug #1447756 in upstart : "segfault in log.c code causes phone reboot loops"
  https://bugs.launchpad.net/upstart/+bug/1447756

For more details, see:
https://code.launchpad.net/~jamesodhunt/upstart/bug-1447756-the-actual-fix/+merge/259020

* init/log.c:
  - log_clear_unflushed(): Handle logs on the unflushed list which
    get flushed automatically by their corresponding NihIo before
    a request to clear the unflushed list is made. This scenario
    is triggered when a job which has spawned processes exits, but
    where the spawned processes continue to run and then produce
    output before the request to clear the unflushed list is made
    (at the time the log partition becomes writable) but after the
    log partition becomes writable (LP: #1447756).
* init/tests/test_log.c:
  - test_log_new(): Added new test:
    "ensure logger unflushed list ignores already flushed data".
  - test_log_destroy(): Improved test
     "ensure unflushed data moved to unflushed list with uid 0" by giving 
    the log a parent and checking parent handling behaviour.
-- 
Your team Upstart Reviewers is requested to review the proposed merge of lp:~jamesodhunt/upstart/bug-1447756-the-actual-fix into lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 6570 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20150513/d1e9b847/attachment.diff>


More information about the upstart-devel mailing list