[Merge] lp:~jamesodhunt/upstart/restrict-debug-stanza into lp:upstart
James Hunt
james.hunt at canonical.com
Fri Jan 31 23:49:24 UTC 2014
James Hunt has proposed merging lp:~jamesodhunt/upstart/restrict-debug-stanza into lp:upstart.
Requested reviews:
Upstart Reviewers (upstart-reviewers)
For more details, see:
https://code.launchpad.net/~jamesodhunt/upstart/restrict-debug-stanza/+merge/204363
Creating a job with a debug stanza will stop stateful re-exec from working reliably since the child is paused before exec'ing such that it still retains a copy of the parents file descriptors. This is legitimate since that is the whole point of the unofficial debug stanza. Since the debug stanza is only to be used for development, no production job should be using it and in fact no production version of Upstart that supports stateful re-exec can be using it due to the problems it causes with re-exec.
As such, this branch makes the debug stanza a NOP unless upstart was *started* with --debug.
--
https://code.launchpad.net/~jamesodhunt/upstart/restrict-debug-stanza/+merge/204363
Your team Upstart Reviewers is requested to review the proposed merge of lp:~jamesodhunt/upstart/restrict-debug-stanza into lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2268 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20140131/8dd7c13e/attachment.diff>
More information about the upstart-devel
mailing list