[Merge] lp:~jamesodhunt/upstart/bug-530779 into lp:upstart
Steve Langasek
steve.langasek at canonical.com
Fri Jan 10 21:07:05 UTC 2014
>> Upstart does not depend on PR_SET_CHILD_SUBREAPER being
>> available on the running kernel - the test suite shouldn't
>> either. The test needs to be skipped if this facility is
>> unavailable, or it needs to be rewritten to avoid subreaper
>> entirely.
> Fixed.
This is not fixed. You've adjusted the test suite to not fail if PR_SET_CHILD_SUBREAPER is not *defined* at build time; this does not address the problem of it being *unsupported* by the running kernel. The 'assert0 (prctl (PR_SET_CHILD_SUBREAPER, 1))' must be dropped from the test suite, and be replaced by a check that skips the test if it's unavailable.
This probably calls for the test to be broken out into a separate function so that it can be skipped sensibly.
--
https://code.launchpad.net/~jamesodhunt/upstart/bug-530779/+merge/197080
Your team Upstart Reviewers is subscribed to branch lp:upstart.
More information about the upstart-devel
mailing list