[Merge] lp:~jamesodhunt/upstart/bug-1302117 into lp:upstart

[James Hunt]

James Hunt has proposed merging lp:~jamesodhunt/upstart/bug-1302117 into lp:upstart.

Requested reviews:
  Upstart Reviewers (upstart-reviewers)
Related bugs:
  Bug #1302117 in upstart : "Session Init changes umask on re-exec"
  https://bugs.launchpad.net/upstart/+bug/1302117

For more details, see:
https://code.launchpad.net/~jamesodhunt/upstart/bug-1302117/+merge/215173

Just prior to re-exec Upstart serialises all the internal objects. As a result, log_serialise() gets called for reach job process. If a job process has unflushed data, Upstart attempts to persist it prior to the re-exec. However, the entails calling log_file_open() *in the parent*, which was setting the umask to ensure the log file is created with a known permission.

The fix was to save the umask, set it, write the log file, then restore the umask.

Also, added a new test to avoid regression.
-- 
https://code.launchpad.net/~jamesodhunt/upstart/bug-1302117/+merge/215173
Your team Upstart Reviewers is requested to review the proposed merge of lp:~jamesodhunt/upstart/bug-1302117 into lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3473 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20140410/558dc29f/attachment.diff>