[Merge] lp:~jamesodhunt/upstart/fix-system-reexec-test into lp:upstart

James Hunt james.hunt at canonical.com
Thu Sep 12 10:58:24 UTC 2013


James Hunt has proposed merging lp:~jamesodhunt/upstart/fix-system-reexec-test into lp:upstart.

Requested reviews:
  Upstart Reviewers (upstart-reviewers)

For more details, see:
https://code.launchpad.net/~jamesodhunt/upstart/fix-system-reexec-test/+merge/185238

Various fixes and improvements to the system and session tests:

* scripts/pyupstart.py:
  - dbus_encode(): Comments.
  - Upstart::_idle_create_job_cb(): Pass retain option.
  - Upstart::job_create(): Allow specification of retain option to keep
    job configuration file on object destruction.
  - Upstart::job_recreate(): New method to vivify a Job object using an
    existing job configuration file.
  - Job::__init__(): New 'retain' and 'reuse_path' options.
  - Job::get_instance(): New method to obtain a Jobs JobInstance.
  - Job::get_dbus_instance(): Renamed from get_instance().
  - JobInstance::destroy(): NOP for 'retain'ed jobs.
* scripts/tests/test_pyupstart_system_init.py:
  - test_pid1_reexec():
    - Retain the job configuration to allow the object to be recreated
      after re-exec.
* scripts/tests/test_pyupstart_session_init.py:
  - test_session_init_reexec: Add job creation for parity with
    test_pid1_reexec().
-- 
https://code.launchpad.net/~jamesodhunt/upstart/fix-system-reexec-test/+merge/185238
Your team Upstart Reviewers is requested to review the proposed merge of lp:~jamesodhunt/upstart/fix-system-reexec-test into lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 14734 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20130912/e596a5e3/attachment-0001.diff>


More information about the upstart-devel mailing list