[Merge] lp:~jamesodhunt/upstart/bug-1238078 into lp:upstart

James Hunt james.hunt at canonical.com
Fri Oct 11 16:23:01 UTC 2013


James Hunt has proposed merging lp:~jamesodhunt/upstart/bug-1238078 into lp:upstart.

Requested reviews:
  Upstart Reviewers (upstart-reviewers)
Related bugs:
  Bug #1238078 in upstart : "global environment table is not serialised"
  https://bugs.launchpad.net/upstart/+bug/1238078

For more details, see:
https://code.launchpad.net/~jamesodhunt/upstart/bug-1238078/+merge/190723

Fix for bug 1238078:

------------------------------------------------------------
revno: 1545
committer: James Hunt <james.hunt at ubuntu.com>
branch nick: upstart-bug-1238078
timestamp: Fri 2013-10-11 17:17:19 +0100
message:
  * test/test_util_common.c:
    - session_init_reexec(): New.
    - set_upstart_session(): Whitespace.
  * test/test_util_common.h: REEXEC_UPSTART(): Update to handle Session
    Inits too.
  * util/man/initctl.8: Clarify 'set-env' behaviour.
  * util/tests/test_initctl.c: New tests:
    - "ensure 'set-env' persists across session-init re-exec".
    - "ensure 'set-env --global' persists across session-init re-exec".
------------------------------------------------------------
revno: 1544
fixes bug: https://launchpad.net/bugs/1238078
committer: James Hunt <james.hunt at ubuntu.com>
branch nick: upstart-bug-1238078
timestamp: Fri 2013-10-11 14:35:51 +0100
message:
  * init/job_class.c:
    - job_class_serialise_job_environ(): New function to serialise global
      job environment table.
    - job_class_deserialise_job_environ(): New function to deserialise global
      job environment table.
  * init/state.c:
    - state_to_string(): Serialise global job environment table
      (LP: #1238078).
    - state_from_string(): Deserialise global job environment table.
    - _state_deserialise_str_array(): Don't attempt to free array if type
      check fails.

-- 
https://code.launchpad.net/~jamesodhunt/upstart/bug-1238078/+merge/190723
Your team Upstart Reviewers is requested to review the proposed merge of lp:~jamesodhunt/upstart/bug-1238078 into lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 12968 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20131011/14e37a2e/attachment.diff>


More information about the upstart-devel mailing list