[Merge] lp:~jamesodhunt/upstart/file-bridge-MP into lp:upstart

Dmitrijs Ledkovs launchpad at surgut.co.uk
Thu Mar 14 19:18:19 UTC 2013


Review: Needs Fixing

Moving start of upstart-file-bridge, after /foo is created, doesn't emit event either.
Moving start of upstart-file-bridge, after /foo/a is created, event is emitted and subdir1 job is started.

If /foo/a/ is created, file bridge started, and /a/ subfolder is deleted & recreated, touching /foo/a/test does not emit an event.

I'm not entirely sure about emitting create events, upon start up either.
For example, in my ssh config I have ControlPath set to ~/.cache/ssh/%r@%h:%p, which can be a stale file. Upon connecting ssh client will notice that it's stale and recreate it and that's when I want my upstart job to start.

I think simple things like this can be easily scripted into a shell based integration test.
I have been using inotifywait -m -r /foo, to check that inotify events are actually emitted.
-- 
https://code.launchpad.net/~jamesodhunt/upstart/file-bridge-MP/+merge/152767
Your team Upstart Reviewers is subscribed to branch lp:upstart.



More information about the upstart-devel mailing list