[Merge] lp:~xnox/upstart/reload-signal into lp:upstart

Dmitrijs Ledkovs launchpad at surgut.co.uk
Mon Jul 22 01:41:27 UTC 2013


Dmitrijs Ledkovs has proposed merging lp:~xnox/upstart/reload-signal into lp:upstart.

Requested reviews:
  Upstart Reviewers (upstart-reviewers)
Related bugs:
  Bug #893021 in upstart : "ability to specify signal for reload command"
  https://bugs.launchpad.net/upstart/+bug/893021

For more details, see:
https://code.launchpad.net/~xnox/upstart/reload-signal/+merge/176099

This branch adds "reload signal" stanza.

Instead of initctl calling kill on the main process, it now calls an instance dbus method Reload.

Reload method, looks up reload_signal and calls kill on the main process with it.

Tests added:
* serialisation/deserialisation
* job configuration parsing
* job_reload() function in init/job.c

Broken tests:
* test_initctl reload_action test currently hangs, and thus is commented out. Help with testing it is appreciated, I guess it now needs to simply test that dbus calls are done in the right order without actually testing that signals were sent to a process, as this is now done in the job_reload() test.
-- 
https://code.launchpad.net/~xnox/upstart/reload-signal/+merge/176099
Your team Upstart Reviewers is requested to review the proposed merge of lp:~xnox/upstart/reload-signal into lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 20628 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20130722/003e1e29/attachment-0001.diff>


More information about the upstart-devel mailing list