[Merge] lp:~jamesodhunt/upstart/add-session-file into lp:upstart

Steve Langasek steve.langasek at canonical.com
Tue Jan 29 09:43:19 UTC 2013


On Tue, Jan 29, 2013 at 09:27:22AM -0000, Dmitrijs Ledkovs wrote:
> > get_subdir (const char *dir, const char *suffix, int create)
> > {
> > [...]
> >         nih_assert (dir != NULL);
> > [...]
> >         if (dir && dir[0] == '/') {
> > [...]

> > Looks like a redundant check for dir's nullness.

> It's a check for absolute path.

That's written 'if (dir[0] == '/')'.  The check for 'dir &&' is what's
redundant.

-- 
https://code.launchpad.net/~jamesodhunt/upstart/add-session-file/+merge/144881
Your team Upstart Reviewers is subscribed to branch lp:upstart.



More information about the upstart-devel mailing list