[Merge] lp:~xnox/upstart/fix-ftbfs-externs into lp:upstart

Dmitrijs Ledkovs launchpad at surgut.co.uk
Mon Feb 11 03:31:19 UTC 2013


Dmitrijs Ledkovs has proposed merging lp:~xnox/upstart/fix-ftbfs-externs into lp:upstart.

Requested reviews:
  Upstart Reviewers (upstart-reviewers)

For more details, see:
https://code.launchpad.net/~xnox/upstart/fix-ftbfs-externs/+merge/147590

we really should i agree on how to handle global vars / externs.
As currently anything that is declared in main.c cannot be extern in the rest of the files, as then tests will fail to link as demonstrated below.
-- 
https://code.launchpad.net/~xnox/upstart/fix-ftbfs-externs/+merge/147590
Your team Upstart Reviewers is requested to review the proposed merge of lp:~xnox/upstart/fix-ftbfs-externs into lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1180 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20130211/91f528b7/attachment.diff>


More information about the upstart-devel mailing list