[Merge] lp:~xnox/upstart/reload-signal into lp:upstart
james.hunt at canonical.com
Wed Aug 21 10:04:28 UTC 2013
The test hang appears to be caused because the tests fake the dbus server responses from pid 1. However, with the new API, we would also need to either:
1) Fake the call to job_reload().
2) Call job_reload() explicitly.
3) Change the test to actually fire up an upstart instance to avoid faking anything.
Option (3) is preferred of course, but since test_job.c:test_reload() is already doing (3), it should be sufficient to simply test the client is making the correct type of request over D-Bus for test_initctl.c.
Your team Upstart Reviewers is requested to review the proposed merge of lp:~xnox/upstart/reload-signal into lp:upstart.
More information about the upstart-devel