[Merge] lp:~stgraber/upstart/upstart-initctl2dot-python3 into lp:upstart

[Steve Langasek]

On Wed, Nov 28, 2012 at 05:10:25PM -0000, Stéphane Graber wrote:
> === modified file 'scripts/initctl2dot.py'
> --- scripts/initctl2dot.py	2011-06-06 12:52:08 +0000
> +++ scripts/initctl2dot.py	2012-11-28 17:09:22 +0000
> @@ -50,522 +50,530 @@
>  import re
>  import fnmatch
>  import os
> -from string import split
>  import datetime
>  from subprocess import (Popen, PIPE)
>  from optparse import OptionParser

Shouldn't this also change the interpreter to /usr/bin/python3?  I don't see
any reason why we would need this script to be bilingual, we ought to just
change it and go.  If people want to use newer versions of upstart on OSes
that don't have python3, then they just won't be able to use this script...
but this is hardly a requirement anyway.

(Also, looking at this I notice we're shipping initctl2dot in /bin in the
Ubuntu package... that doesn't make much sense when the interpreter is in
/usr/bin.)

-- 
https://code.launchpad.net/~stgraber/upstart/upstart-initctl2dot-python3/+merge/136721
Your team Upstart Reviewers is requested to review the proposed merge of lp:~stgraber/upstart/upstart-initctl2dot-python3 into lp:upstart.