[PATCH] usage stanza
james.hunt at ubuntu.com
Thu Feb 16 14:08:43 UTC 2012
On 16/02/12 09:28, Lukáš Nykrýn wrote:
> I want to ask if this patch is considered to be included in next upstart
> release or if it needs some alteration.
Hi Lukáš, Petr,
Apologies for the delay in responding to this. Yes, I'd like to include this feature in the next
release. The changes Petr made are now allowing me to use the feature. However, there are a few
issues that still need to be addressed:
- Missing return code check for "error_message = nih_strdup (...)".
This could result in a crash resulting from follow-on usage.
- nih_strcat_sprintf() check calls nih_error_raise_no_memory(), but
does not immediately return -1. If nih_strcat_sprintf() fails,
should really just call nih_return_system_error(). As it is, I
think problems would result since 2 errors are being raised in
that block and only 1 will be consumed by the caller, leading to a
possible assertion failure in the NIH alloc code.
- job_class_start(): As above.
* util/initctl.c:job_usage(): Should state "Returns: newly allocated
string or NULL on raised error.".
More information about the upstart-devel