[Merge] lp:~stgraber/upstart/upstart-tests-pty into lp:upstart

[Stéphane Graber]

Stéphane Graber has proposed merging lp:~stgraber/upstart/upstart-tests-pty into lp:upstart.

Requested reviews:
  Upstart Reviewers (upstart-reviewers)

For more details, see:
https://code.launchpad.net/~stgraber/upstart/upstart-tests-pty/+merge/140388

This fixes our current PPA build hang.

PPA don't allow writting to /dev/tty (for some weird reason), so upstart
uses a pty instead. However the function setting up the pty was a bit wrong
as it was doing a waitpid on the child before starting the mainloop watching
for the output coming to the pty.

So as soon as the pty buffer was full, everything would hang.

This simply moves the mainloop start before the waitpid, fixing the hang.
-- 
https://code.launchpad.net/~stgraber/upstart/upstart-tests-pty/+merge/140388
Your team Upstart Reviewers is requested to review the proposed merge of lp:~stgraber/upstart/upstart-tests-pty into lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 527 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20121218/fbd77be4/attachment.diff>