[Merge] lp:~stgraber/upstart/upstart-shell-exec into lp:upstart

[Stéphane Graber]

Stéphane Graber has proposed merging lp:~stgraber/upstart/upstart-shell-exec into lp:upstart.

Requested reviews:
  Upstart Reviewers (upstart-reviewers)

For more details, see:
https://code.launchpad.net/~stgraber/upstart/upstart-shell-exec/+merge/140233

This should hopefully fix the job_process test for good.

The previous change was setting job->script = TRUE whenever shell syntax was
found on the command line. Sadly this was causing the code to then go through
a different code path and skip prepending "exec" to the shell command line.
This ultimately was causing a test to hang when run in a directory containing
shell syntax in its path.

The fix reverts that change and instead always sets script = TRUE but only at
the very end of the processing, so the code path doesn't change but the
property is still properly set so tests can use it.
-- 
https://code.launchpad.net/~stgraber/upstart/upstart-shell-exec/+merge/140233
Your team Upstart Reviewers is requested to review the proposed merge of lp:~stgraber/upstart/upstart-shell-exec into lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1255 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20121217/a14c68ae/attachment-0001.diff>