[Merge] lp:~stgraber/upstart/upstart-dbus-events into lp:upstart

Stéphane Graber stgraber at stgraber.org
Thu Dec 13 15:24:25 UTC 2012


Stéphane Graber has proposed merging lp:~stgraber/upstart/upstart-dbus-events into lp:upstart.

Requested reviews:
  Upstart Reviewers (upstart-reviewers)

For more details, see:
https://code.launchpad.net/~stgraber/upstart/upstart-dbus-events/+merge/139726

This branch implements two new signals:
 - Restarted
   Emitted after upstart has restarted.
 - EventEmitted
   Emitted whenever an event is emitted, two parameters are set, one is a list
   of all the environment variables and values, the other is the blocking
   state of the event.

I also extended the current testsuite to test for the EventEmitted signal.
Doing this caught a bug in libnih where it'd fail with an assert when passed an
empty list for the 'as' type.
This has since been fixed in the libnih Ubuntu package.

There's currently no tests for the Restarted event as I wasn't too sure where
to put one, considering that the test would depend on the presence of the DBUS
system bus and of a running upstart with re-exec support.
The system bus is required for the Restarted event as it's almost impossible to
re-attach to the private bus quickly enough to receive the Restarted event.
-- 
https://code.launchpad.net/~stgraber/upstart/upstart-dbus-events/+merge/139726
Your team Upstart Reviewers is requested to review the proposed merge of lp:~stgraber/upstart/upstart-dbus-events into lp:upstart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 4822 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/upstart-devel/attachments/20121213/44ab391f/attachment.diff>


More information about the upstart-devel mailing list