utmp handing (Was: [RFC][PATCH] Add support for oom_score_adj)

[Petr Lautrbach]

On 03/21/2011 04:12 PM, Scott James Remnant wrote:
> Ah, great; I remember seeing a patch from you as well that added the
> ability to do "utmp ${TTY#tty}" did that get submitted?
>

No, that is different method.
Code included in current upstart tries to determine utmp_id itself according to
utmp table and process pid without need to change job.

unlike utmp ${TTY#tty} patch needs to change tty jobs. It is probably more precious as
it use almost same procedure as SysVInit. But the need of changing jobs was dead end
for fedora.

I've seen request in lanchpad to reselect merge target and
I hope I'll do it soon.

Petr


> On Mon, Mar 21, 2011 at 8:11 AM, Petr Lautrbach<plautrba at redhat.com>  wrote:
>> On 03/21/2011 04:07 PM, Scott James Remnant wrote:
>>>
>>> What is the unmerged part, OOI? I thought I had taken all your
>>> changes, but it seems not.
>>>
>>> Scott
>>
>> this email's [1] 3rd attachment [2]
>>
>>
>> [1] https://lists.ubuntu.com/archives/upstart-devel/2011-January/001363.html
>> [2]https://lists.ubuntu.com/archives/upstart-devel/attachments/20110105/ab27f4e9/attachment-0002.ksh
>>
>> Petr
>>
>>>
>>> On Mon, Mar 21, 2011 at 8:05 AM, Petr Lautrbach<plautrba at redhat.com>
>>>   wrote:
>>>>
>>>> On 03/18/2011 11:09 PM, Scott James Remnant wrote:
>>>>>
>>>>> Cc'ing Petr
>>>>>
>>>>> On Thu, Mar 17, 2011 at 3:27 PM, Marc - A. Dahlhaus<mad at wol.de>
>>>>>   wrote:
>>>>>>
>>>>>> Am 17.03.2011 21:45, schrieb Scott James Remnant:
>>>>>>
>>>>>>> On Thu, Mar 17, 2011 at 11:58 AM, Marc - A. Dahlhaus<mad at wol.de>
>>>>>>>   wrote:
>>>>>>>
>>>>>>>> BTW is the override file stuff upstreamed into the 1.X branch
>>>>>>>> already?
>>>>>>>>
>>>>>>> No. I wanted to release a stable 1.0 with no new features, James
>>>>>>> needed to get features in for Ubuntu natty - so for now Ubuntu is
>>>>>>> running a fork of Upstart (whichout all the bug fixes of 1.0 + 1.1,
>>>>>>> but with new features).
>>>>>>
>>>>>> while we are at it, i had some problems regarding utmp handling in 1.0
>>>>>> and
>>>>>> while running a gdb session and talking with plauterbach on irc he
>>>>>> suggested
>>>>>> adding this patch: http://plautrba.fedorapeople.org/upstart-utmp.patch
>>>>>>
>>>>>> The patch fixed the utmp handling on my box which is running an LFS
>>>>>> based
>>>>>> system with unpatched upstream versions of glibc-2.13, util-linux-2.19
>>>>>> (agetty) and shadow-4.1.4.3 (login).
>>>>>>
>>>>>> The problem was that upstart couldn't find the first opened utmp record
>>>>>> on
>>>>>> logout from local ttys for each tty after a clean boot. The behavior
>>>>>> was
>>>>>> the
>>>>>> same even on a empty utmp file after a boot. SSH ttys where handled
>>>>>> correctly
>>>>>> so a buggy glibc was ruled out in our tests.
>>>>>>
>>>>>> I didn't debugged it further after i found out that the patch mentioned
>>>>>> above
>>>>>> fixed the bug for me.
>>>>>>
>>>>> Yeah, after reviewing some merges I think I managed not to get the
>>>>> entirety of those patches.
>>>>>
>>>>> Petr - what am I missing?
>>>>>
>>>>
>>>> Really don't know.
>>>>
>>>>   From my point of view, merged changes do work fine for me regardless on
>>>> non-pushed part.
>>>> I will try to reproduce it with latest util-linux and clear upstart-1.1
>>>> sources without any fedora patches but
>>>> since I've already tried few things and everything's went as expected ...
>>>>
>>>> Regards,
>>>>
>>>> Petr
>>>> --
>>>> Petr Lautrbach, Red Hat, Inc.
>>>>
>>
>>
>> --
>> Petr Lautrbach, Red Hat, Inc.
>>


-- 
Petr Lautrbach, Red Hat, Inc.