[RFC][PATCH] Add support for oom_score_adj
Marc - A. Dahlhaus
mad at wol.de
Thu Mar 17 21:52:48 UTC 2011
Am 17.03.2011 21:48, schrieb Scott James Remnant:
> (Replying to the new patch separately)
>
> On Thu, Mar 17, 2011 at 11:58 AM, Marc - A. Dahlhaus <mad at wol.de> wrote:
>
>> The never case was no problem as i set booth values on never.
>> But i get your point. Rewrote it per your comments. Result attached.
>>
> This looks perfect, could you add some tests for "oom score" to the
> parsing code, I see you've already updated the existing ones.
Of course, it wouldn't compile without the changes...
I add some tests for to large and to small values and also a overwrite value
check...
I also thought about adding two helpers for the value calculation from and to
score values to a header so that we have a single place which holds the
calculations and don't need to add the calculation to every test.
It also
> needs a man page update (I suggest just dropping "oom NN" out of the
> man page and replacing it with "score")
will do.
> Then it looks ready to apply!
> Thankyou,
> Scott
OT:
It looks like init/errors.h is missing in the po/POTFILES.in file list
(working on adding a de.po but it's not very high on my priority list).
http://upstart.at/download/1.x/upstart-1.1.tar.gz doesn't have the right rights as i get an 403 Forbidden on it...
Thanks,
Marc
More information about the upstart-devel
mailing list