[Bug 424238] Re: [MIR] kasumi

[Loïc Minier]

Some comments on packaging:
- please add ${misc:Depends}, recommended by dh >= 5 (I wonder why lintian doesn't catch it here)
- debian/copyright doesn't mention the GPL version (v2 or later) -- and the builtin copy of intl/ but that's common
- please avoid passing --host if you aren't cross compiling as this causes configure to turn the cross-compiling flag on
- you dont actually create configure-stamp and config.status is already a good enough configure-stamp; instead of:
config.status: configure
configure: configure-stamp
configure-stamp: patch-stamp
>-------stuff
Use:
configure: config.status
config.status: patch-stamp
>-------stuff
and make sure you list configure in .PHONY since it's also a real file but the intended behavior isn't to check this file's timestamp
- dont test for -r /usr/share/misc/$$file, it's always there per build-deps
- if the config.status rules gets run twice by a developer, config.*.orig will contain /usr/share/misc/config.* contents and clean will restore these; that's really minor though
- cd po; make update-gmo; cd ../ => $(MAKE) -C update-gmo

Upstream uses an old AM_PATH_GTK_2_0 macro; this should be changed to
PKG_CHECK_MODULES; this might be causing superfluous link flags.

Please add a gettext domain to kasumi.desktop.in for rosetta support; do
we really want to add a new entry in the settings menu that late in the
cycle and for a very specific app which most people dont need to
configure?

It seems no .pot is generated during build but I dont understand why
pkgstriptranslations doesn't pick up the po/*pot file.  Could you please
run $(MAKE) -C po kasumi.pot-update during build (after configure) to
make sure it's always up-to-date even if we patch strings?

These warnings indicate that the intl and po dirs have out of date Makefile.ins:
config.status: WARNING:  intl/Makefile.in seems to ignore the --datarootdir setting
...
config.status: WARNING:  po/Makefile.in.in seems to ignore the --datarootdir setting
we dont care about intl but upstream probably wants to fix both (running the relevant tools such as gettextize is probably enough).

This error suggest you're missing some docbook data during build:
xsltproc -nonet -o debian/kasumi.1 /usr/share/xml/docbook/stylesheet/nwalsh/manpages/docbook.xsl  debian/kasumi.xml 
I/O error : Attempt to load network entity http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd
debian/kasumi.xml:45: warning: failed to load external entity "http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd"
]>
  ^


So I'd love if you could work on copyright and rules to fix at least the licensing, pot and configure .PHONY issues.

Thanks,

** Changed in: kasumi (Ubuntu)
     Assignee: (unassigned) => Loïc Minier (lool)

** Changed in: kasumi (Ubuntu)
       Status: New => Incomplete

-- 
[MIR] kasumi
https://bugs.launchpad.net/bugs/424238
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs at lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs