[Bug 482944] Re: Please merge pcmanx-gtk2 0.3.8-3 (universe) from Debian testing (main)

[Fabrice Coutadeur]

Nice job: it's a complex merge, and it seems to be done very well.
I only have some comments on the debdiff:
- why do you delete part of the patch iceape-dev.dpatch ? You don't apply it after, so it could stay as-is
- instead of duplicating almost the full content of the patch iceape-dev.dpatch, I would have made a smaller patch on the top of this patch
- there are 2 translation files in your debdiff. They shouldn't be there

Otherwise, looks good.

Thanks to fix those small issues.

Fabrice


** Changed in: pcmanx-gtk2 (Ubuntu)
       Status: In Progress => Incomplete

** Changed in: pcmanx-gtk2 (Ubuntu)
     Assignee: Fabrice Coutadeur (fabricesp) => (unassigned)

-- 
Please merge pcmanx-gtk2 0.3.8-3 (universe) from Debian testing (main)
https://bugs.launchpad.net/bugs/482944
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs at lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs