[Bug 381384] Re: mod_deflate with mod_fastcgi gives wrong content-length header

[Martin von Gagern]

For those interested in mod_fastcgi development in general, or in the
greater context of the upstream fix, I'm attaching a diff between the
2.4.6 release and the SNAP-0811090952 snapshot source tree. I've written
to the fastcgi-developers mailing list, pointing at this issue here and
asking as to when a release containing this fix can be expected. As I'm
not subscribed to the list, my post is still awaiting approval.

Comparison of the possible fixes:

http://www.yl.is.s.u-tokyo.ac.jp/~oiwa/pub/unix/fastcgi-content-length.patch
Uses headers_out, errors on duplicate Content-Length headers.

http://article.gmane.org/gmane.comp.web.fastcgi.devel/2613
Uses ap_set_content_length instead of headers_out.

SNAP-0811090952 according to attached patch
Uses headers_out, no check for duplicate Content-Length headers.

The snapshot also removes duplicate header checks in other cases, so this is consistent.
For the Content-Type header there is a case distinction, and it uses ap_set_content_type for APACHE2. ap_set_content_length sounds like a counterpart to this, but I guess upstream had reasons to change the patch from the one sent to them, and Content-Type was somwhat different in Apache 1 builds as well, as it had a dedicated field instead of the headers_out table.

On the whole, I'd go with the upstream changes.

** Attachment added: "Changes in SNAP-0811090952"
   http://launchpadlibrarian.net/27247918/mod_fastcgi-2.4.6-to-SNAP-0811090952.patch

-- 
mod_deflate with mod_fastcgi gives wrong content-length header
https://bugs.launchpad.net/bugs/381384
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs at lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs