[Bug 333462] Re: nautilus crashed with SIGSEGV in strlen()

Christian Neumair cneumair at gnome.org
Sat May 16 06:43:42 UTC 2009


I am the Nautilus-Open-Terminal maintainer. It looks like the patch
proposed in bug 309529 comment 18 introduces custom URI parsing, instead
of reusing the GnomeVFS functions, probably for completely migrating
away from GnomeVFS. We should instead wait until the string parsing
landed in glib before migrating wway. I understand that the lack of a
release for the last few months created an unfortunate situation, sorry
for that. I just released Nautilus-Open-Terminal 0.10.

However, regarding the patches: Guys, there is a reason why complex
string parsing should be done by libraries instead of hand-crafting it.
Judging from the diff [1], the parsing does not look robust. One
possibility would be to migrate back to GnomeVFS as in Nautilus-Open-
Terminal [2], but I don't know how feasible this is for a stable
release.

I am attaching a unit test for the string parsing function used by
Ubuntu, to allow further debugging.

[1] http://launchpadlibrarian.net/20583606/nautilus-open-terminal_0.9-3ubuntu1.debdiff
[2] http://git.gnome.org/cgit/nautilus-open-terminal/tree/src/nautilus-open-terminal.c?id=NAUTILUS_OPEN_TERMINAL_0_10#n131

** Attachment added: "unit test for Ubuntu's hand-crafted URI parsing"
   http://launchpadlibrarian.net/26800710/test.c

-- 
nautilus crashed with SIGSEGV in strlen()
https://bugs.launchpad.net/bugs/333462
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs at lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs




More information about the universe-bugs mailing list