[Bug 298424] Re: sl-modem-daemon init.d script looks for information about ALSA modem in wrong place

[Martin Pitt]

Some comments:

 - Please don't call egrep and aplay -l twice. Do it once, save it in $output, and just use the variable.
 - I suspect that it also greps /proc/asound/cards further down. Please move that upwards and reuse the grep result.
 - echo $output -> echo "$output", to avoid automatic bash expansion
 - test "$line" -> [ -n "$line" ]  for clarity and safety
 - readability: what should "if ! line=$() && line=$()" mean? Please don't mix tests and assignments with && and ||.

Can you please test it again with above changes and attach an updated
patch? Once that still works, the change should also be submitted as a
Debian bug.

Thank you!

** Changed in: sl-modem (Ubuntu)
       Status: New => Incomplete

-- 
sl-modem-daemon init.d script looks for information about ALSA modem in wrong place
https://bugs.launchpad.net/bugs/298424
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs at lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs