[Bug 306974] Re: Wishlist: Replace LMMS 0.3.2 with LMMS 0.4.0

[Iulian Udrea]

Thank you for the updated version.  Unfortunately, I still have some
remarks.

You've added a build-dep on g++ and make.  You don't need to add them,
because they are included in the build essential package.  You may add
them only if a particular version of that package is required.  That
being said, if you need them, please add their version as well.

You can remove dpatch from Build-Depends, we don't need it anymore as
there are no more patches.

You bumped debhelper's version and you didn't mention it in
debian/changelog.

You've also removed libqt3-i18n from Depends.  Is there a reason why you
did this?  Please document that in debian/changelog as well.

Please note that it is very important to document every change you made
to a package in debian/changelog.  That will help us to see what was
changed and so forth.

I think that's all.  The next version might be uploaded.

Thank you for your work.

-- 
Wishlist: Replace LMMS 0.3.2 with LMMS 0.4.0
https://bugs.launchpad.net/bugs/306974
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs at lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs