[Bug 499599] Re: stops after generating 5-6 thumbnails

[Hadmut Danisch]

OK, I found two bugs:

- gnome-raw-thumbnailer parses Sony RAW files like TIFF files and recursively parses the TIFF-Tree-Tag 014a. However, 
  Sony RAW files have these tags and the offset as described, but there seems to be no regular IFD structure at this place, but  
  some different sort of data. On the other hand, gnome-raw-thumbnailer is poorly written software without any range check or 
  catching error states. So it runs into an undefined loop when parsing Sony files. But when commenting out that recursive 
  call, it works. (But I have no idea whether this breaks reading other file formats than Sony). 

- at the end of main() there's a  g_free (fname) which causes a
segmentation fault. Commenting this out might leave some memory
allocated, which doesn't really cause problems because the program
terminates immediately. But it lets the program terminate cleanly and
without segfault.


After fixing these to problems it works for me (at least for sony files). Don't know if blocking the recursion of 014a tags causes any trouble with other file formats. 

regards

-- 
stops after generating 5-6 thumbnails
https://bugs.launchpad.net/bugs/499599
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs at lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs