[Bug 277556] Re: should build kernel modules with dkms

[Evan Broder]

grexk: thanks for the patch. A few nits for future reference:
 - LP closers are generally of the form (LP: #nnnnnn) - you didn't have the hash
 - It looks like you added a superfluous line to set SRC_VERSION in debian/rules
 - Your version number was appropriate for a PPA upload, but not for uploading to Ubuntu. There's some discussion of version numbering schemes at <https://wiki.ubuntu.com/UbuntuDevelopment#Working%20with%20Ubuntu%20Packages>

Of course, packages that support building kernel modules with module-
assistant are special. For those packages, it's necessary to use
+ubuntu1 instead of just ubuntu1 in order to avoid version sorting
issues.

I've combined grexk's patch with my patch for bug #391224 with the
recommendations on using dkms in bug #497149. I've uploaded a test build
to my PPA (https://launchpad.net/~broder/+archive/ubuntu-tests), and I'm
attaching the resulting debdiff. I'm going to do some testing to make
sure everything's in order, and hopefully I'll be able to upload tonight
or tomorrow.

** Attachment added: "open-vm-tools_2009.11.16-210370-1+ubuntu1.debdiff"
   http://launchpadlibrarian.net/36960306/open-vm-tools_2009.11.16-210370-1%2Bubuntu1.debdiff

-- 
should build kernel modules with dkms
https://bugs.launchpad.net/bugs/277556
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs at lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs