[Bug 410228] Re: main inclusion report plasma-widget-indicatordisplay

[Loïc Minier]

Packaging looks good, minor points:
- Priority should be optional.
- You might want to add a watch file.
- I see CMakeLists.txt uses pkg-config checks but there's no cmake or kde package deping on it, so I don't know where the pkg-config functions come from but you might have to explicitly build-depend on pkg-config

There's an issue with licensing:
- upstream files lack the full license grant (the blob saying this file is under GPL and you should have received it etc.), they only have "License: GPL v3"
- plenty of files are actually LGPL; this is worth representing in the debian/copyright file at least, or fixing upstream; please ship a copy of the COPYING.LGPL file if you ship files under the LGPL

Upstream code: looks good.

What's the issue with running the testsuite in dbus-launch?

Please subscribe to the bug mail for this package or subscribe the
responsible team.

** Changed in: plasma-widget-indicatordisplay (Ubuntu)
       Status: New => Incomplete

** Changed in: plasma-widget-indicatordisplay (Ubuntu)
     Assignee: (unassigned) => Loïc Minier (lool)

-- 
main inclusion report plasma-widget-indicatordisplay
https://bugs.launchpad.net/bugs/410228
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs at lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs