virtualbox-ose: FTBFS: uncleaned LocalConfig.kmk

[Anon Sricharoenchai]

Package: virtualbox-ose
Version: 1.5.6-dfsg-6ubuntu1
Severity: serious
Justification: no longer builds from source

*** Please type your report below this line ***

== Steps to reproduce ==

1. boot into ubuntu 8.04.1 live DVD
2. $ aptitude install devscripts build-essential fakeroot
   $ dget http://archive.ubuntu.com/ubuntu/pool/universe/v/virtualbox-ose/virtualbox-ose_1.5.6-dfsg-6ubuntu1.dsc
   $ dpkg-source -x virtualbox-ose_1.5.6-dfsg-6ubuntu1.dsc
   $ cd virtualbox-ose-*/
3. Install build dependencies for virtualbox-ose
4. Build virtualbox-ose,

   $ fakeroot dpkg-buildpackage -b -i
   <--cut-->
   ...
   <--cut-->
   test -d debian/patched || install -d debian/patched
   dpatch  apply-all
   applying patch 01-no-64bit-guest to ./ ... ok.
   applying patch 02-2.6.25 to ./ ... ok.
   applying patch 03-config-kmk to ./ ... ok.
   applying patch 04-localconf-kmk to ./ ... failed.
   make: *** [patch-stamp] Error 1
   dpkg-buildpackage: failure: debian/rules build gave error exit status 2


== Cause ==

04-localconf-kmk.dpatch expected LocalConfig.kmk as empty file, but it
is not empty as shown by this,

   $ gzip -cd virtualbox-ose_1.5.6-dfsg-6ubuntu1.diff.gz | tail
   <--cut-->
   ...
   <--cut-->
   --- virtualbox-ose-1.5.6-dfsg.orig/LocalConfig.kmk
   +++ virtualbox-ose-1.5.6-dfsg/LocalConfig.kmk
   @@ -0,0 +1 @@
   +VBOX_WITH_X11_ADDITIONS=1

   $ dpkg-source -x virtualbox-ose_1.5.6-dfsg-6ubuntu1.dsc
   $ cd virtualbox-ose-*/
   $ cat LocalConfig.kmk
   VBOX_WITH_X11_ADDITIONS=1

This is because "debian/rules clean" does not clean the lines in
LocalConfig.kmk inserted by env.sh rule,

   env.sh: patch-stamp
   	<--cut-->
   	echo "VBOX_WITH_X11_ADDITIONS=1" >> LocalConfig.kmk

Let's look at the following steps,

   $ rm -f LocalConfig.kmk
   $ fakeroot ./debian/rules env.sh
   <success>
   $ fakeroot ./debian/rules clean
   $ cat LocalConfig.kmk
   VBOX_WITH_X11_ADDITIONS=1
   $ fakeroot ./debian/rules env.sh
   <--cut-->
   applying patch 04-localconf-kmk to ./ ... failed.
   make: *** [patch-stamp] Error 1

This shows that the package can't be rebuilt again, after it has been
once built and cleaned.


(The information generated below is irrelevant, since I'm not using this
machine to build the package that producing this bug.)

-- System Information:
Debian Release: testing/unstable
  APT prefers warty-updates
  APT policy: (800, 'warty-updates'), (800, 'warty-security'), (800,
'warty-backports'), (800, 'warty'), (700, 'hoary-updates'), (700,
'hoary-security'), (700, 'hoary-backports'), (700, 'hoary'), (600,
'breezy-updates'), (600, 'breezy-security'), (600,
'breezy-backports'), (600, 'breezy'), (599, 'dapper-updates'), (599,
'dapper-security'), (599, 'dapper-backports'), (599, 'dapper'), (500,
'gutsy-backports'), (500, 'feisty-backports'), (500, 'edgy-backports')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15-52-386
Locale: LANG=C, LC_CTYPE=thai (charmap=TIS-620)