[Bug 420931] Re: zsync crashes with SIGSEGV when updating dvds

[Steve Beattie]

On Thu, Sep 03, 2009 at 05:13:44AM -0000, Daniel Holbach wrote:
> Is there any upstream bug about this where the problem is discussed too?

Poking around http://zsync.moria.org.uk/ , no, it
doesn't appear that there is, nor is there in debian's
BTS (it looks like the upstream author is also the debian
maintainer).  However, if you look at rev 5 in ubuntu's history
(http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/karmic/zsync/karmic/revision/5),
you'll see in http.c lines 635-640 (in the committed version) where
global_offset is being added by ubuntu.

You can get upstream's bzr tree at http://zsync.moria.org.uk/zsync/
though it's not web browsable (it's not big, there's only 92 revisions).
Revision 39 changes the types of "from" and "to" in question (c/http.c's
diff chunk annotated with "@@ -676,25 +683,28 @@") from an int to off_t
(along with a lot of other similar changes); unfortunately, the commit
message is the unhelpful:

  $ bzr log -c 39
  ------------------------------------------------------------
  revno: 39
  committer: Colin Phipps <cph at moria.org.uk>
  branch nick: zsync
  timestamp: Sat 2006-08-05 17:43:19 +0100
  message:
    Fix off_t and size_t format strings.
    tabs -> spaces.
    stdint.h in zmap.c, for MacOS X.

which doesn't explain the why. Revision 39 corresponds to version 4.3 =>
5.0 in the upstream releases.

I've attached the full diff for rev 39 for your perusal, though of
course, looking at upstream's bzr tree is recommended as well.

Another way to fix this would be to drop the undocumented -O
(global_offset) in the first place; this would significantly minimize
our difference from upstream.  I can't find any reference as to why we
added support for it. If that's the preferred solution, I can generate
that patch as well.

-- 
Steve Beattie
<sbeattie at ubuntu.com>
http://NxNW.org/~steve/


** Attachment added: "zsync-offt_sizet_conversions-rev39.patch"
   http://launchpadlibrarian.net/31266472/zsync-offt_sizet_conversions-rev39.patch

-- 
zsync crashes with SIGSEGV when updating dvds
https://bugs.launchpad.net/bugs/420931
You received this bug notification because you are a member of Ubuntu
Sponsors for universe, which is a direct subscriber.