[Bug 317894] Re: grandr not in menu

[James Westby]

Hi Jacob,

Thanks for working on this, it looks much better now.

I assume to fix the lintian warning you just deleted the "-" at the start of
that line? If so, then that will cause problems. Usually the way to fix this is
to call "distclean" as "[ ! -f Makefile ] || $(MAKE) distclean" which handles
the usual case of the Makefile not being there as ./configure hasn't been run
without masking other errors.

(Did you know you can get lintian to tell you more about each problem?
I usually run it as "lintian -iIv" which gives lots of possible issues and lots
of information about each.)

I think you can file the bug now, and a bug about the Vcs-Browser change you
made would be good as well.

As for the rest of the changes, I have a few comments/questions.

  * Seeing the modifications to the Makefiles is odd, do you know why they are
     changing?
  * It is against Ubuntu policy to modify the Standards-Version in a package that
     originates from Debian, as there is little use for this change, and it is not done
     across the board, so it just adds noise and can lead to spurious conflicts.
  * Why did you change the comment in the desktop file as well?
  * Removing the extension from the icon name is good, but is there not a display-capplet
     icon installed? Is it in the source package and just missed from being installed?
  * Please remove the extra new-line from the Build-Depends field, it doesn't cause any
     harm, but it needn't be there.

If you can clear up these issues, or explain why they are the way they are then I will
happily sponsor this change.

Thanks,

James

-- 
grandr not in menu
https://bugs.launchpad.net/bugs/317894
You received this bug notification because you are a member of Ubuntu
Sponsors for universe, which is a direct subscriber.