[Bug 276945] Re: [intrepid] menu buttons don't work on main page

[James Westby]

Hi Charlie,

It looks almost perfect now. There is one issue left

 exit 0
+
+if [ "$1" = "purge" ] && [ -e /usr/share/debconf/confmodule ]; then
+	. /usr/share/debconf/confmodule
+	db_purge
+	db_stop
+fi

so the code you added will never execute as it comes after an
exit 0 call.

The last bit of

  http://www.fifi.org/doc/debconf-doc/tutorial.html#AEN158

explains what should happen on purge, and states that using
dh_installdebconf will do this for you. ampache uses debhelper,
and so that will be taken care of.

Therefore I think you can safely delete this bit of code and not
worry about the db_purge command.

I would do this for you and upload, but I would like you to double
check and perhaps test.

Another comment I would have, but it's not something that will stop
me uploading this change, is that you should try and explain
why you are doing things in the changelog. For example

+    * Updated debian/rules to read dh_install -Xprototype.

explains what was done, but I can see that just by reading the diff.
What the changelog gives you is a chance to explain why you did
these things. Doing that makes it a lot easier for other people to
understand your changes.

Thanks,

James

-- 
[intrepid] menu buttons don't work on main page
https://bugs.launchpad.net/bugs/276945
You received this bug notification because you are a member of Ubuntu
Sponsors for universe, which is a direct subscriber.