[Bug 276945] Re: [intrepid] menu buttons don't work on main page

[James Westby]

Hi,

This one looks pretty good, I just have a couple of questions left.

-         ln -s /etc/ampache/ampache.conf /etc/$webserver/conf.d/ampache
+         ln -s /etc/ampache/ampache.conf /etc/$webserver/conf.d/ampache.conf

is this needed? There's no transition, so forever more code in maintainer
scripts would have to take account of both paths, e.g.

+   #This is needed to manually remove symlink.
+   if [ -h /etc/apache2/conf.d/ampache.conf ]; then
+      rm -f /etc/apache2/conf.d/ampache.conf

this now won't remove the old symlink will it? So people who use ampache on
Hardy, upgrade to Intrepid, and then purge will still have this symlink.

+    * Added prototype symlink back to debian/links reworked server restart
+      script. (LP: #276945)
+    * Fixed debian/ampache.postrm by fixing server restart and by adding
+      db_purge and db_stop in the correct order.
+      remove /etc/apache2/conf.d/ampache to make ampache purge 
+      correctly.
+    * Added mkdir /usr/share/ampache/www/modules/prototype to debian/rules.
+    * Updated debian rules to read -Xprototype.

I'd like it if you could rework this, as I think the iterative updates have muddled
it slightly. For instance the first bullet point seems to be two conceptual changes,
your diff doesn't add db_purge or db_stop, and you don't add the mkdir call
to debian/rules.

Thanks,

James

-- 
[intrepid] menu buttons don't work on main page
https://bugs.launchpad.net/bugs/276945
You received this bug notification because you are a member of Ubuntu
Sponsors for universe, which is a direct subscriber.